LibWeb: Relax HTML parser to allow more tags inside <select> #6899
Conversation
F3n67u
force-pushed
the
relax-html-parser-customizable-select
branch
3 times, most recently
from
3d10f52 to
31d1a2f
Compare
| Pass html5lib_innerHTML_tests_innerHTML_1.html 9210d577d6deecf5ab3505af86c501c5befa0b50 | ||
| Pass html5lib_innerHTML_tests_innerHTML_1.html c34af491c0a339db6ba63fcc478108533347319b | ||
| Pass html5lib_innerHTML_tests_innerHTML_1.html 2c4284e6b2bb480daa50bca43bcbe29cfcdeeab4 | ||
| Fail html5lib_innerHTML_tests_innerHTML_1.html 2c4284e6b2bb480daa50bca43bcbe29cfcdeeab4 |
There was a problem hiding this comment.
Why are we now failing this test though?
There was a problem hiding this comment.
Currently the spec doesn't allow <input> in <select> (See whatwg/html#11288).
This test was updated from:
#data
<input><option>
#errors
(1,7): unexpected-input-in-select
#document-fragment
select
#document
| <option>to
#data
<input><option>
#errors
#document-fragment
select
#document
| <input>
| <option>With this change, the test now expects no parse errors when an <input> is placed inside <select>. That's why the test is currently failing.
The only remaining failure in html/semantics/forms/the-select-element/customizable-select/select-parsing.html comes from the same issue.
These appears to be Chrome-specific expectations, since Chrome passes all of these tests - meaning chrome has already implemented support for allowing <input> in <select>.
There was a problem hiding this comment.
Makes sense - could you leave a little note about this in the commit message?
There was a problem hiding this comment.
Updated. please take another look. Thanks!
This implements parsing part of customizable <select> spec update. See whatwg/html PR #10548. Two failing subtests in `html5lib_innerHTML_tests_innerHTML_1.html` and `customizable-select/select-parsing.html` are due to the spec still disallowing `<input>` inside `<select>`, even though Chrome has already implemented this behavoir (see whatwg/html#11288).
F3n67u
force-pushed
the
relax-html-parser-customizable-select
branch
from
31d1a2f to
7f64bc2
Compare
2 participants
This implements parsing part of customizable spec update. See whatwg/html#10548.